Skip to content
This repository was archived by the owner on Nov 28, 2018. It is now read-only.

Move default getClientIp to use proxy-addr, just like express does.#63

Open
pdefreitas wants to merge 6 commits intoryanbillingsley:masterfrom
pdefreitas:master
Open

Move default getClientIp to use proxy-addr, just like express does.#63
pdefreitas wants to merge 6 commits intoryanbillingsley:masterfrom
pdefreitas:master

Conversation

@pdefreitas
Copy link

Includes #61 which bumps lodash version to fix security issues. Typos fixed in the readme.
Removes allowedHeaders in favour of proxy-addr (to streamline with Express behind proxies).
For more info and discussion check issue #62

@jetersen
Copy link

@pdefreitas perhaps it would be good to republish as express-ipfilter2 ? since this is unmaintained?

@jetersen
Copy link

jetersen commented Oct 22, 2018

@baminteractive @coopman @nsbingham do you intend to maintain the package or could someone take ownership or at least be maintainer?

@pdefreitas
Copy link
Author

@Casz I can republish this project as express-ipfilter2 tomorow. I don't think the current owner of the repo is active.

@jetersen
Copy link

@pdefreitas could you try ask NPM transferring ownership first 😅

@jetersen
Copy link

@pdefreitas
Copy link
Author

pdefreitas commented Oct 31, 2018

@Casz thanks for sharing, I have contacted NPM and the NPM project owner.

@ryanbillingsley
Copy link
Owner

ryanbillingsley commented Oct 31, 2018

I followed up with @pdefreitas but just so every one knows, I left the company a while back so I haven't been able to administer this at all. I reached out to see if I can get the ownership transferred and will let you know what happens

@jetersen
Copy link

thanks for the update @ryanbillingsley 🙌

@ryanbillingsley
Copy link
Owner

@pdefreitas @Casz as you may have noticed, the repo was transferred back to me. I will look at this PR as soon as I can this evening.

I mentioned it on #61, but I do want to get that version in before pushing a new major version out so I will try and get that taken care of if it isn't already by the time I can get to it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants