Fix [SyncWorker] attribute failing for typed ref parameters#838
Merged
notfood merged 1 commit intorwmt:masterfrom Mar 19, 2026
Merged
Fix [SyncWorker] attribute failing for typed ref parameters#838notfood merged 1 commit intorwmt:masterfrom
notfood merged 1 commit intorwmt:masterfrom
Conversation
Member
|
Looks fine. The impact is mostly to other mods that use |
Contributor
Author
|
Yeah, it can fix CE's patch. And should work with other too. |
TheCallunxz
added a commit
to TheCallunxz/Multiplayer
that referenced
this pull request
Mar 19, 2026
Fix [SyncWorker] attribute failing for typed ref parameters (rwmt#838)
Contributor
Author
|
Small problem that this patch forget to use preserved addGenericMethod, very small performance problem when Initializing game, if someone read this try replace line 68 here with addGenericMethod.Invoke(this, [func]). shall works fine. |
Member
|
Huh?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For me there are 2 ways to fix this:
Chose the first one because: