Use scan instead of keys for gets #97
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atn18
suggested changes
Feb 10, 2020
| /** Get a list of keys using the wildcard */ | ||
| self.client.keys(prefix + ':' + name, domain.intercept(function (keys) { | ||
| if ( ! keys.length ) { | ||
| self.client.scan(0, 'match', prefix + ':' + name, domain.intercept(function (result) { |
There was a problem hiding this comment.
You are going to perform only one SCAN iteration which could return empty results set, so to find all matching keys you will need to repeat scanning till the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
KEYScommand is really expensive in production. With ~500 ops/sec latency for reads and writes was between 5-7 seconds. Using theSCANcommand instead reduced latency to manageable sub-second levels.