Skip to content

Fix this.connected bug when connect event is missed #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willyjchen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix this.connected bug when connect event is missed #96

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40b8b7b
Fix this.connected bug when connect event is missed
willyjchen Aug 25, 2017
81bddda
Update ExpressRedisCache.js
willyjchen Feb 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/ExpressRedisCache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ module.exports = (function () {
this.emit('disconnected', { host: this.host, port: this.port });
this.emit('message', 'Disconnected from redis://' + this.client.host + ':' + this.client.port);
}.bind(this));

if ( this.client.connected ) {
this.client.emit('connect');
Copy link

@atn18 atn18 Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think resending connect on client is not good idea. Because there could be some subscribers that will not expect this.
You should better directly set self.connected.

}
}
}

Expand Down