Skip to content

Conversation

@fikander
Copy link

Accumulate content in a buffer on res.write. Save the buffer as cache on res.end

@smulder
Copy link

smulder commented Jan 10, 2018

Did this make it anywhere?

@fikander
Copy link
Author

fikander commented Jan 10, 2018

It hasn't been merged, but this branch is being used in prod in our project.

@smulder
Copy link

smulder commented Jan 10, 2018

Before I bug you to much for a peak at some code... do you think it would support Marko templates (if your familiar) they require a writeable stream as their out and don’t call send on res. Not sure what is called to actually finish the send, but I don’t remember end being fired on res either.

@smulder
Copy link

smulder commented Jan 10, 2018

Also, did you end up working to remove domain from your version by any chance?

@fikander
Copy link
Author

@smulder sorry I don't know what Marko templates are.
I didn't remove domain.

@smulder
Copy link

smulder commented Jan 10, 2018

I just ported your code over to my copy and it works excellent, puts the easy middleware use back in my situation rather than having to custom code each route.

Thank you for doing that, bummer they never merged it!

@fikander
Copy link
Author

Perfect. Glad it worked for you. I was surprised it wasn't there in the first place - looks like a common scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants