Skip to content

Extend usage to restify #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willfarrell wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Extend usage to restify #71

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd0c8bc
Extend usage to restify
willfarrell Aug 6, 2016
ed03663
fix github editor auto formating
willfarrell Aug 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/ExpressRedisCache/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,11 @@ module.exports = (function () {
/** if it's cached, display cache **/

if ( cache.length ) {
res.contentType(cache[0].type || "text/html");
if (res.contentType) {
Copy link

@markberryman markberryman Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can avoid this conditional by using res.header which is supported by Express v4.x and Restify.

res.contentType(cache[0].type || "text/html");
} else if (res.setHeader) {
res.setHeader('content-type', cache[0].type || "text/html");
}
Copy link
Contributor

@bsyk bsyk Aug 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like spaces are being used elsewhere in this project. Would you consider uses spaces instead of tabs for consistency?

Copy link
Author

@willfarrell willfarrell Aug 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, serves me right for doing it in the browser. All fixed.

if(binary){ //Convert back to binary buffer
res.send(new Buffer(cache[0].body, 'base64'));
}else{
Expand Down