Skip to content

Move redis into devDependencies #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
golmansax wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move redis into devDependencies #137

golmansax wants to merge 1 commit into from

Conversation

@golmansax
Copy link

@golmansax golmansax commented Oct 8, 2021 •
edited
Loading

Fixes #130. npm test passes locally after this change. Decided against using optionalDependencies as it sounds like npm install still installs optionalDependencies. Not sure if peerDependency makes sense as it will show a warning when redis is not installed.

What do you think?

@golmansax
Copy link
Author

golmansax commented Oct 19, 2021

@rawpixel-vincent This is a PR as requested for #130

@demsking
Copy link

demsking commented Apr 27, 2022

redis should me moved to the peerDependencies as it's used as the main dependency by express-redis-cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Thoughts on removing 'redis' as a dependency?

2 participants

@golmansax @demsking