Fix: Wire up missing Vuex mutation setCalibrationPattern and calibValidationResult state#119
Open
midaa1 wants to merge 1 commit intoruxailab:mainfrom
Open
Fix: Wire up missing Vuex mutation setCalibrationPattern and calibValidationResult state#119midaa1 wants to merge 1 commit intoruxailab:mainfrom
midaa1 wants to merge 1 commit intoruxailab:mainfrom
Conversation
…tion never defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PostCalibration.vue'sapplyCalibResult()method was silently broken across two missing links:calibValidationResultfrom the predict store — a property that never existed in statesetCalibrationPattern— a mutation that was never defined incalibration.jsThe method always exited at the null-guard, meaning the adapted calibration pattern (with prediction coordinates, precision, and accuracy) was never reactively stored. Post-calibration visualizations only worked because
DoubleCalibrationRecord.vuewas directly mutating pattern objects in place — bypassing Vuex reactivity entirely and leaving the app in a fragile, unpredictable state.Changes
src/store/predict.jscalibValidationResultto state +setCalibValidationResultmutationsrc/store/calibration.jssetCalibrationPatternmutation to properly setruntime.usedPatternsrc/views/DoubleCalibrationRecord.vuesetCalibValidationResultwith prediction data after API response, so the result is available whenPostCalibrationmountsWhy this matters
Without this fix, any future code that relies on
calibValidationResultbeing populated would silently discard the adapted pattern and renderdrawCalibPoints()with nopredictionX/predictionY— producing empty visualizations and NaN centroids. This PR closes that latent failure path and replaces the direct mutation workaround with a proper reactive store flow.