refactor: separate UI from calibration logic in DoubleCalibrationRecord.vue (#112)#117
Open
harsshks wants to merge 5 commits intoruxailab:mainfrom
Open
refactor: separate UI from calibration logic in DoubleCalibrationRecord.vue (#112)#117harsshks wants to merge 5 commits intoruxailab:mainfrom
harsshks wants to merge 5 commits intoruxailab:mainfrom
Conversation
- Enter fullscreen during training and validation - Exit fullscreen on completion or route leave - Fix camera preview being clipped by stepper container - Allow natural scrolling during calibration Fixes ruxailab#100
- Add calibration mode selection (multi-point vs single-point) - Update store with calibrationMode state and mutations - Add single-point pattern generation (center screen) - Update DoubleCalibrationRecord.vue to support single-point mode - Add calibration mode selector in CameraConfiguration.vue - Dynamic stepper content based on calibration mode - Maintain backward compatibility with existing multi-point mode Features: - Quick single-point calibration for faster setup - Lower accuracy trade-off for speed - Center screen point positioning - Dynamic UI based on selected mode - Proper state management integration Addresses ruxailab#99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #112
Refactors DoubleCalibrationRecord.vue by extracting calibration math and webcam handling into dedicated modules, reducing the component by ~245 lines and improving separation of concerns.
Changes
New Files
src/services/CalibrationCalculator.js — Pure utility functions (no Vue dependencies):
src/mixins/CameraMixin.js — Reusable Vue mixin for webcam/MediaRecorder:
Modified Files
Why This Matters
Testing
npx vue-cli-service build)Dependencies