refactor: remove unused imports and variables#38
Open
rachana192837 wants to merge 1 commit intoruxailab:mainfrom
Open
refactor: remove unused imports and variables#38rachana192837 wants to merge 1 commit intoruxailab:mainfrom
rachana192837 wants to merge 1 commit intoruxailab:mainfrom
Conversation
Contributor
Author
|
@BasmaElhoseny01 can u review this PR ? would be really helpful . Thanks |
Collaborator
BasmaElhoseny01
left a comment
BasmaElhoseny01
left a comment
There was a problem hiding this comment.
LGTM will test & we can merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the codebase by removing unused code (imports and variables) discovered by running the
flake8linter.Changes Made
app/__init__.py: Removed the unusedloggerimport.app/models/whisper_model.py: Removed the unusedimport torch.app/routes/audio_transcript_sentiment_routes.py: Removed the unusedevariable in the exception block.app/services/audio_transcription_sentiment_pipeline.py: Removed the unusedtimestamp = chunk['timestamp']variable assignment, which was declared but never utilized.Motivation
Removing dead code improves maintainability, prevents developer confusion, and ensures the codebase adheres more closely to strict Python linting standards (
flake8), which is great for long-term project health.