fix: add audio_url support to /transcribe endpoint for remote audio files#17
Open
sohampirale wants to merge 1 commit intoruxailab:mainfrom
Open
fix: add audio_url support to /transcribe endpoint for remote audio files#17sohampirale wants to merge 1 commit intoruxailab:mainfrom
sohampirale wants to merge 1 commit intoruxailab:mainfrom
Conversation
Author
|
@jvJUCA Can you please take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
This PR adds support for
audio_urlparameter to the/transcribeendpoint, allowing the frontend to send audio file url from Firebase storage instead of requiring local file paths.Fixes : #16
Changes Made
/transcribeendpoint to accept bothfile_pathandaudio_urlparametersAudioServicefor remote audio filesfile_pathoraudio_urlis provided (but not both)audio_urlfieldaudio_urlfield name to maintain consistency with existing frontend implementationNote on Schema Mismatch
While implementing this feature, we discovered a schema mismatch between what the backend returns and what the frontend expects. The backend endpoints (
/transcribeand/chunks) return data in a different format than what the frontend is designed to render. Specifically:This will require corresponding frontend changes to properly handle the data returned by these endpoints.
Testing
Verified that the endpoint works with both
file_pathandaudio_urlinputsConfirmed that validation prevents sending both parameters simultaneously
Tested cleanup of temporary files when using URL input
Ensured backward compatibility with existing
file_pathusageWorking successfully with frontend
file_pathaudio_url