Sanitized file_name and calib_id to prevent path traversal attacks#90
Open
ChaitanyaChute wants to merge 1 commit intoruxailab:mainfrom
Open
Sanitized file_name and calib_id to prevent path traversal attacks#90ChaitanyaChute wants to merge 1 commit intoruxailab:mainfrom
ChaitanyaChute wants to merge 1 commit intoruxailab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #89
Summary
This PR fixes a path traversal vulnerability in
app/routes/session.pywhere user-supplied inputs (file_nameandcalib_id) were directly used to construct file paths without validation.Both values are now sanitized using
sanitize_filename()before being used in filesystem operations.Security Issue
Previously,
file_nameandcalib_idwere used directly in file paths:Because these values came directly from user input, an attacker could exploit path traversal by submitting values such as:
This could allow writing files outside the intended directory and potentially overwrite sensitive system or application files.
Fix Implemented
A
sanitize_filename()function is now applied to bothfile_nameandcalib_idbefore path construction.The function:
os.path.basenamea-zA-Z0-9-_.Files Modified