Skip to content

Refactoring #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Refactoring #9

wants to merge 45 commits into from

Conversation

Spown
Copy link
Contributor

@Spown Spown commented May 18, 2017 •
edited
Loading

Resubmitting my refactoring once again.

  1. explicitly run localization only on registered i18n paths (no duck typing or guessing) which makes the process faster and more error prone
  2. added Number, Boolean support
  3. options.defaultLocale
  4. more flexible morphology of the methods
  5. tests
  6. CI, security, coverage

Spown and others added 30 commits December 25, 2016 05:47
ignore .vscode
b9f5e4a
Refactoring: No duck typing i.e. .to(Obbject/JSON)[only] methods trav…
eb2e680 
…erse only the 1i8ned paths, v0.2.1
Tests: dropping DB before start; running validation tests after colle…
c53ab53 
…ction is reindexed (no unique: true check is possible without)
added Error on no locale arguments in methods, v 0.2.2
68561ee
Check locale name argument validity; fix skipping some i18n paths
635d5b8
Check locale name argument validity;
b20bc0b
Don't try to localyze missing fileds
c0407f4
syncing
b254c0b 
# Conflicts:
#	index.js
syncing
7400418 
# Conflicts:
#	package.json
works with String, Number, Boolean, Date; options.defaultLocale; bugf…
868c671 
…ixes; tests; readme
travis, appveyor, codeclimate
c747a86
travis, appveyor, codeclimate; package.json npm jshint
96287f7
ci's
6d9a1ed
ci's: mongodb
5b05d73
^devDeps
d3db63c
@pballester
support for i18n fields with empty nested objects
f8a31c0
Merge pull request #2 from pballester/master
cdeda6c 
support for i18n fields with empty nested objects
tests: m, typo
a8618df
~ better polymorph; + _i18n_paths internal data (rudimentary for now;…
183fb96 
… 0.3.1)
~ m
9b45317
~ m
fe5b407
~ fix for Automattic/mongoose#5695; v0.3.2
9e413a0
- work on document array; + badges
2ef2a33
~ deps, cover
43b04fa
~ .gitignore
8d8d5ae
+ .codeclimate.yml
c799730
~ climate
ff520b4
~ climate
82c0757
~ climate
13037e8
~ climate, m
210f56f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Spown @pballester