Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getters, setters, and constructors compiler errors for enums #4278

Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ad495c9
Make `getter`s, `setter`s, and `constructor`s compiler errors for enums
RunDevelopment Nov 18, 2024
e967962
Better error messages
RunDevelopment Nov 18, 2024
888ead1
rustfmt
RunDevelopment Nov 18, 2024
77c3696
Merge branch 'main' into error-enum-getter-setter-constructor
RunDevelopment Nov 29, 2024
f07b885
Add `rustversion` and `diagnostic` feature
RunDevelopment Nov 29, 2024
526400f
Different code gen for static asserts
RunDevelopment Nov 29, 2024
81f2d43
Use Rust 1.78.0 to run UI tests
RunDevelopment Nov 29, 2024
9342b6d
Fixed span
RunDevelopment Nov 29, 2024
0f75414
Updated other ui tests
RunDevelopment Nov 29, 2024
95715ec
Export marker traits under `::__rt::marker`
RunDevelopment Nov 29, 2024
4a83589
Merge branch 'main' into error-enum-getter-setter-constructor
RunDevelopment Dec 7, 2024
053c60e
Feature suggestions
RunDevelopment Dec 7, 2024
db953cc
Shared check struct
RunDevelopment Dec 7, 2024
ed462cc
Fixed main debug warning
RunDevelopment Dec 7, 2024
6ac1419
Terser error messages
RunDevelopment Dec 7, 2024
2802d40
Removed `extern crate rustversion`
RunDevelopment Dec 8, 2024
9355f5c
Merge branch 'main' into error-enum-getter-setter-constructor
RunDevelopment Dec 8, 2024
49f6c4d
Move `marker.rs` file under `rt`
RunDevelopment Dec 8, 2024
7512b07
Document `msrv` feature
RunDevelopment Dec 8, 2024
5e461ff
Remove useless `automatically_derived`
RunDevelopment Dec 8, 2024
bd9f847
Updated UI tests
RunDevelopment Dec 8, 2024
80ab2ef
Update changelog
RunDevelopment Dec 8, 2024
b240d26
Apply suggestions from code review
RunDevelopment Dec 8, 2024
e1d2358
Test MSRV and resolver v1 of new crate feature
daxpedda Dec 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated UI tests
  • Loading branch information
RunDevelopment committed Dec 8, 2024
commit bd9f84712a3f0fa6e9bf848381cfa82f7e0dbe24
10 changes: 5 additions & 5 deletions crates/macro/ui-tests/unsupported-options.stderr
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ error[E0277]: JavaScript constructors are not supported for `RustEnum`
= note: Consider removing the `constructor` option and using a regular static method instead.
= help: the trait `SupportsConstructor` is implemented for `RustStruct`
note: required by a bound in `CheckSupportsConstructor`
--> $WORKSPACE/src/marker.rs
--> $WORKSPACE/src/rt/marker.rs
|
| pub struct CheckSupportsConstructor<T: SupportsConstructor>(T);
| ^^^^^^^^^^^^^^^^^^^ required by this bound in `CheckSupportsConstructor`
@@ -31,7 +31,7 @@ error[E0277]: JavaScript instance getters and setters are not supported for `Rus
= note: `#[wasm_bindgen(getter)]` and `#[wasm_bindgen(setter)]` are only supported for `struct`s and cannot be used for `enum`s.
= help: the trait `SupportsInstanceProperty` is implemented for `RustStruct`
note: required by a bound in `CheckSupportsInstanceProperty`
--> $WORKSPACE/src/marker.rs
--> $WORKSPACE/src/rt/marker.rs
|
| pub struct CheckSupportsInstanceProperty<T: SupportsInstanceProperty>(T);
| ^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `CheckSupportsInstanceProperty`
@@ -50,7 +50,7 @@ error[E0277]: JavaScript instance getters and setters are not supported for `Rus
= note: `#[wasm_bindgen(getter)]` and `#[wasm_bindgen(setter)]` are only supported for `struct`s and cannot be used for `enum`s.
= help: the trait `SupportsInstanceProperty` is implemented for `RustStruct`
note: required by a bound in `CheckSupportsInstanceProperty`
--> $WORKSPACE/src/marker.rs
--> $WORKSPACE/src/rt/marker.rs
|
| pub struct CheckSupportsInstanceProperty<T: SupportsInstanceProperty>(T);
| ^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `CheckSupportsInstanceProperty`
@@ -69,7 +69,7 @@ error[E0277]: JavaScript static getters and setters are not supported for `RustE
= note: `#[wasm_bindgen(getter)]` and `#[wasm_bindgen(setter)]` are only supported for `struct`s and cannot be used for `enum`s.
= help: the trait `SupportsStaticProperty` is implemented for `RustStruct`
note: required by a bound in `CheckSupportsStaticProperty`
--> $WORKSPACE/src/marker.rs
--> $WORKSPACE/src/rt/marker.rs
|
| pub struct CheckSupportsStaticProperty<T: SupportsStaticProperty>(T);
| ^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `CheckSupportsStaticProperty`
@@ -88,7 +88,7 @@ error[E0277]: JavaScript static getters and setters are not supported for `RustE
= note: `#[wasm_bindgen(getter)]` and `#[wasm_bindgen(setter)]` are only supported for `struct`s and cannot be used for `enum`s.
= help: the trait `SupportsStaticProperty` is implemented for `RustStruct`
note: required by a bound in `CheckSupportsStaticProperty`
--> $WORKSPACE/src/marker.rs
--> $WORKSPACE/src/rt/marker.rs
|
| pub struct CheckSupportsStaticProperty<T: SupportsStaticProperty>(T);
| ^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `CheckSupportsStaticProperty`
Loading