Execute websocket test assertions #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should fully solve #368 now @carlsverre, I just realized that I basically stole your code (even though I looked at it afterwards). If you care about the contribution credit, this should be your PR |
|
All good! Don't care about contribution credit in this case, just that it's fixed. Thanks for working on it! I guess leave eventsource fixes for a future pr? |
Probably add it to this one if I can get it done int the next 10 mins |
The assertions were not doing anthing before, they were only queued to run
richardpringle
force-pushed
the
remove-spawn-local-from-net
branch
from
bc2b641 to
af48424
Compare
|
I could not for the life of me get the tests in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertions were not doing anthing before, they were only queued to
run
Proof that they are running now: #393
Fixes: #368