-
Notifications
You must be signed in to change notification settings - Fork 68
Expose KeyPurposeId::to_decoded_oid() #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
=======================================
Coverage 97.43% 97.44%
=======================================
Files 20 20
Lines 4101 4104 +3
=======================================
+ Hits 3996 3999 +3
Misses 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it'd be nice to wait for conclusive end to end confirmation this is the last bit of tweaking needed for the OP that kicked off this work before we publish another release.
That was my plan exactly! |
@sgrams ping? Any thoughts? |
I was able to populate RequiredEkuNotFoundContext::present without the need of this commit. |
How did you write it? |
To help external
ExtendedKeyUsageValidator
s fillRequiredEkuNotFoundContext::present
.