Skip to content

Add Dockerfile #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aawsome merged 2 commits into from
Dec 16, 2023
Merged

Add Dockerfile #969

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ebf6d8
build: add Dockerfile
Vatson112 Dec 15, 2023
c172da0
build: migrate to slim image, delete RUSTIC_NO_CACHE
Vatson112 Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Improve build speed with cached deps
ARG RUST_VERSION=1.70.0
FROM lukemathwalker/cargo-chef:latest-rust-${RUST_VERSION} AS chef
WORKDIR /app

FROM chef AS planner
COPY . .
RUN cargo chef prepare --recipe-path recipe.json

FROM chef AS builder
COPY --from=planner /app/recipe.json recipe.json
# Build dependencies - this is the caching Docker layer!
RUN cargo chef cook --release --recipe-path recipe.json
# Build application
COPY . .
RUN cargo build --release

# why we dont use alpine for base image - https://andygrove.io/2020/05/why-musl-extremely-slow/
FROM debian:bookworm as runtime
Copy link
Member

@aawsome aawsome Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why you don't use the slim variant here?

Copy link
Contributor Author

@Vatson112 Vatson112 Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I will change it with next commit.


COPY --from=builder /app/target/release/rustic /usr/local/bin

# usually container will be used with --rm option
# so we ignore cache
ENV RUSTIC_NO_CACHE=true
Copy link
Member

@aawsome aawsome Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to note that using remote repositories without a cache can be very slow...
For many commands even using a cache which is directly removed after execution of the binary is in this case even faster than using no cache at all. So I would remove this, actually.

Copy link
Contributor Author

@Vatson112 Vatson112 Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey. Also remove it with next commit


ENTRYPOINT ["/usr/local/bin/rustic"]