kvm-bindings: fix feature inconsistencies #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that there is a flaw in upstream kvm-bindings that wasn't caught so far. Some parts of the serde feature also need the fam-wrappers feature. This was first discovered here [0] [1]. [0] rust-vmm#350 [1] https://buildkite.com/rust-vmm/kvm-ci/builds/1463/steps/canvas?jid=01995738-26ed-4e8c-9e14-c3f23d6de434 Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
phip1611
requested review from
acatangiu,
andreeaflorescu,
lauralt,
sameo,
roypat and
ShadowCurse
as code owners
|
ah shit, thanks for catching! Another case for running |
roypat
approved these changes
Sep 22, 2025
phip1611
added a commit
to phip1611/kvm-rs
that referenced
this pull request
Sep 22, 2025
This is a back-port of [0] to fix the CI. [0] rust-vmm#351 Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
ShadowCurse
approved these changes
Sep 22, 2025
roypat
pushed a commit
that referenced
this pull request
Sep 25, 2025
This is a back-port of [0] to fix the CI. [0] #351 Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Turns out that there is a flaw in upstream kvm-bindings that wasn't caught so far. Some parts of the serde feature also need the fam-wrappers feature.
This was first discovered here [0] [1].
[0] #350
[1] https://buildkite.com/rust-vmm/kvm-ci/builds/1463/steps/canvas?jid=01995738-26ed-4e8c-9e14-c3f23d6de434
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.