Switch to the stable channel 🎉 #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! This will make a lot of people (I know) happy 😁 |
nicholasbishop
force-pushed
the
bishop-switch-to-stable-2
branch
3 times, most recently
from
5df873f to
4b5f143
Compare
|
@phip1611 ping on review for this :) |
|
Sorry! Somehow, I often miss if someone sets me as a reviewer. GitHub doesn't send notifications in that case, does it? PS: Just learned about https://github.com/pulls/review-requested |
As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
The feature has been stabilized so we don't need to enable it anymore.
As of Rust 1.68, the uefi crates work on stable. Remove the `channel = "nightly"` setting from `rust-toolchain.toml` and `template/rust-toolchain.toml`. Related changes: * The CI job to compile with the MSRV has been changed from `nightly-2022-11-22` to `1.68`. So for now the MSRV job isn't checking anything that isn't already checked by other jobs, but once 1.69 comes out it will. * The CI job to test the latest crates.io release still needs the nightly toolchain until we do a new release. * Some of the uefi-macros compiler ui tests have been modified so that the error output matches the errors produced by stable compiler, which are currently slightly different in a few cases from the nightly compiler. In particular, the precise spans we output for errors in the guid macros don't work on stable, because proc-macro's Literal::subspan method is currently unstable.
nicholasbishop
force-pushed
the
bishop-switch-to-stable-2
branch
from
4b5f143 to
adaa4ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.68 is out, so we can use the stable channel now. This PR includes #617 and #636, removes nightly from the rust-toolchain files, updates the CI, and updates various docs.
Closes #452
Closes #638
Checklist