Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtask: fix nixfmt + update Nix flake + fix CI #1607

Merged
merged 6 commits into from
Apr 7, 2025
Merged

xtask: fix nixfmt + update Nix flake + fix CI #1607

merged 6 commits into from
Apr 7, 2025

Conversation

phip1611
Copy link
Member

@phip1611 phip1611 commented Apr 6, 2025

Please look into the commits.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611 phip1611 requested a review from nicholasbishop April 6, 2025 19:35
@phip1611 phip1611 changed the title xtask: fix nixfmt + update Nix flake xtask: fix nixfmt + update Nix flake + fix CI Apr 6, 2025
Copy link
Member

@nicholasbishop nicholasbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: last commit just says "a", maybe intended to be amended to the previous commit?

phip1611 added 6 commits April 7, 2025 10:00
nixfmt wants to be called with arguments of files to check
and does not walk the tree by itself.
We now get a fresh Rust 1.86 toolchain from Nix.
This simplifies to get all the relevant tools.
We are linting the repo, not just Rust.
We separate the build log from the formatting log.
@phip1611 phip1611 enabled auto-merge April 7, 2025 08:01
@phip1611 phip1611 added this pull request to the merge queue Apr 7, 2025
Merged via the queue into main with commit 0fc6aaf Apr 7, 2025
20 checks passed
@phip1611 phip1611 deleted the fix-fmt branch April 7, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants