Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uefi: Some convenient DevicePathUtilities helper methods #1599

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

seijikun
Copy link
Contributor

@seijikun seijikun commented Apr 1, 2025

Add nice helper methods on DevicePath to construct a new path by appending two paths.

  • I need this for the pass-thru stuff
  • I had to move the PoolDevicePath* stuff around a bit. But they IMHO make more sense where they are now anyway, since those are generally useful.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@seijikun seijikun force-pushed the mr-devpathutil branch 5 times, most recently from 4c2df0b to 92f5cb9 Compare April 1, 2025 21:58
Copy link
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for yet another good contribution! Can we add an integration test for this, please?

@phip1611 phip1611 mentioned this pull request Apr 6, 2025
10 tasks
@seijikun seijikun force-pushed the mr-devpathutil branch 3 times, most recently from 1b47a1c to c602151 Compare April 7, 2025 12:08
@phip1611
Copy link
Member

phip1611 commented Apr 7, 2025

Thanks! I hope I can review (and merge) this within the next 48 hours. 🎉

@phip1611
Copy link
Member

phip1611 commented Apr 8, 2025

I resolved the merge conflict in the GitHub UI. Thanks for your contribution!

@phip1611 phip1611 enabled auto-merge April 8, 2025 07:39
@phip1611 phip1611 added this pull request to the merge queue Apr 8, 2025
Merged via the queue into rust-osdev:main with commit 6ab3d14 Apr 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants