Skip to content

doc: move misc stuff from README to lib.rs [doc: 2/N] #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

phip1611
Copy link
Member

@phip1611 phip1611 commented Aug 6, 2024

This is split-out 2/N from #1264 to improve reviewability.

This moves misc stuff from README to lib.rs

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611 phip1611 changed the title doc: move misc stuff from README to lib.rs [doc: 2/n] doc: move misc stuff from README to lib.rs [doc: 2/N] Aug 6, 2024
@phip1611 phip1611 requested a review from nicholasbishop August 6, 2024 15:13
uefi/src/lib.rs Outdated
//!
//! The full text of the license is available in the [license file][LICENSE].
//!
//! # Trivia and Background
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should drop this section in the interest of keeping the crate docs focused on the most useful information. The history of UEFI is interesting, but not particularly relevant to developing an app with uefi-rs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just drop the entire paragraph. It is irrelevant. We are already referring to the UEFI spec. This is sufficient

uefi/src/lib.rs Outdated
//! of low-level applications.
//!
//! Even joke projects such as an [IRC client][uefirc] leveraging only existing
//! UEFI boot services are possible! 😉
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather leave the IRC client out of the crate docs. (Especially since it's not currently maintained, I wouldn't want to give the impression that users should look there to see how to call uefi-rs.)

As an alternative, I wouldn't be opposed to putting it in the readme if we added a showcase section, e.g. "Projects that use uefi-rs".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just drop the entire paragraph. It is irrelevant. We are already referring to the UEFI spec. This is sufficient

We are already referring to the UEFI spec which is sufficient.
Copy MSRV, License, and Contributing sections to lib.rs and streamline it
with the README equivalents. We should also include these information in
lib.rs, as it is the main entry point into everything relevant about the
library. At least, it should from now on.

The big benefit is that the documentation on `docs.rs` then covers
everything relevant.
@nicholasbishop nicholasbishop added this pull request to the merge queue Aug 7, 2024
Merged via the queue into rust-osdev:main with commit a9ffae8 Aug 7, 2024
13 checks passed
@phip1611 phip1611 deleted the doc3 branch August 7, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants