Skip to content

Conversation

marti4d
Copy link
Collaborator

@marti4d marti4d commented May 7, 2025

Fixes #142

@marti4d
Copy link
Collaborator Author

marti4d commented May 7, 2025

@gabrielesvelto @Jake-Shadle You're going to want to review only ea7b747. The other two commits are from the other two open PRs.

@gabrielesvelto
Copy link
Contributor

Gonna review this ASAP. Thank you @marti4d

@gabrielesvelto
Copy link
Contributor

BTW we might want to add a "validation" step to the list of modules we've generated, to spot problematic cases like those we encountered in the wild. For example, if we find two modules with the same name but different debug IDs.

@marti4d marti4d force-pushed the rendez_vous branch 5 times, most recently from fcd1ac4 to 350da9b Compare July 21, 2025 18:32
@marti4d marti4d requested a review from gabrielesvelto August 7, 2025 17:51
Copy link
Contributor

@gabrielesvelto gabrielesvelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly stylistic/readability changes but I was also curious about the hard-coded page size in the code.

Copy link
Contributor

@gabrielesvelto gabrielesvelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@gabrielesvelto
Copy link
Contributor

@marti4d do you want to double-check the Android failures or shall I merge?

@marti4d
Copy link
Collaborator Author

marti4d commented Sep 26, 2025

I am going to spend some time trying to look into them, but it's weird. I don't see the issue in my local emulator, or on real Android devices. So it makes me wonder if there's something going on with CI, or if the emulator is just running too slow on weak hardware?

Either way, maybe I should try even more to figure it out before we merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the debugger rendez-vous to populate the module list on Linux

2 participants