Make pull request assignment loading more robust #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
open-prs-refactor
branch
from
3871503 to
0d6967e
Compare
Urgau
reviewed
Apr 7, 2025
fbstj
reviewed
Apr 7, 2025
Urgau
reviewed
Apr 8, 2025
Urgau
approved these changes
Apr 9, 2025
To avoid an unnecessary GitHub REST API call.
To get updated state from GitHub without depending only on webhooks.
It is much faster.
Since there are no more one-off jobs
Kobzol
force-pushed
the
open-prs-refactor
branch
from
0d6967e to
9fdede1
Compare
|
Well, it's hard to really confirm something with triagebot 😆 But it seems to be loading fine for me locally. I added a small log to give us information when the loading starts and ends. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements the loading of open pull requests and their assignments to GitHub users. In particular, it changes the implementation from a GraphQL query to REST API calls, which is 5-10x faster based on my measurements, and should avoid the timeouts that I saw in production logs. It also performs this fetch periodically, every 30 minutes, so that we can periodically synchronize the latest state and thus paper over any potentially missed webhooks.
The initial state is also loaded eagerly when triagebot starts, so that we always have a consistent state of the world. If triagebot started without it, it could (in the future, once the workqueue is taken into account) for some time assign PRs based on the assumption that no reviewer has any assigned PRs, which is not great.
Best reviewed commit by commit.
The last two commits remove the GQL query, which is now unused, and also the one-off job mechanism, since the only job that was using it is now a cron job instead.