Improve major change opening comment #1914
Conversation
|
Important This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Concerns or objections can formally be registered here by adding a comment.
Concerns can be lifted with: See documentation at https://forge.rust-lang.org |
|
If we also want to remove the pings that would be here for T-compiler: |
| ``` | ||
| @rfcbot resolve reason-for-concern | ||
| ``` | ||
| See documentation at [https://forge.rust-lang.org](https://forge.rust-lang.org/compiler/mcp.html#what-kinds-of-comments-should-go-on-the-tracking-issue-in-compiler-team-repo) |
There was a problem hiding this comment.
Same here, I think its place is better outside the collapsible text (to avoid being "hidden")
| > Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed. | ||
|
|
||
| <details> | ||
| <summary>Concerns or objections can formally be registered here by adding a comment.</summary> |
There was a problem hiding this comment.
small suggestion: I would put this sentence outside the <detail> tag or it will probably end up being less readable in the email notification.
There was a problem hiding this comment.
I hacked the same HTML generated in the UI in an email (it's probably not exactly the same, but good enough), and it looks fine, same as in the web UI.
There was a problem hiding this comment.
Important
This issue is not meant to be used for technical discussion. There is a Zulip stream for that.
Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
Concerns or objections can formally be registered here by adding a comment.
@rfcbot concern reason-for-concern
<description of the concern>
Concerns can be lifted with:
@rfcbot resolve reason-for-concern
See documentation at https://forge.rust-lang.org
r? @apiraino
There was a problem hiding this comment.
I hope it will look good also on text only emails. I'll report it it's not the case.
This PR tries to improve the major change opening comment by putting the concerns and objections paragraph behind a
<details>block.It also took the opportunity to remove those ugly
\n \in the code.cc @apiraino