-
Notifications
You must be signed in to change notification settings - Fork 334
feat: disable-other-publish-methods default value true
#2147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: disable-other-publish-methods default value true
#2147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR changes the default value of disable-other-publish-methods (mapped to trusted_publishing_only in the API) from false to true for crates.io trusted publishing configuration. This makes trusted publishing the default enforcement mechanism for crate publishing, requiring repositories to explicitly opt-out if they want to allow other publishing methods.
Key Changes
- Changed the default value of
disable_other_publish_methodsfield in the schema fromfalsetotrue - Updated documentation to reflect the new default behavior
- Updated test expectations to match the new default value
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/schema.rs |
Changed serde default attribute from default to default = "default_true" for disable_other_publish_methods field |
docs/toml-schema.md |
Updated documentation comment and example to show default is now true instead of false |
tests/static-api/_expected/v1/repos.json |
Updated test expectations for trusted_publishing_only from false to true |
tests/static-api/_expected/v1/repos/some_repo.json |
Updated test expectations for trusted_publishing_only from false to true |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dry-run check results |
|
You requested copilot review? I didn't change any setting, so not sure why it reviewed the PR 🤔 |
No, I didn't. I'm also surprised why this would happen. Whoops, I found the option and disabled it 🙂 Screen.Recording.2025-12-03.at.2.50.22.PM.mov |
Oh, ok, so it's a personal setting. Ok good to know. If you find it useful, feel free to enable it 👍 |
Kobzol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I wonder why the dry run is empty. Do the crates whose publishing we represent in team already have trustpub_only enabled? 🤔
|
Actually, nevermind, we don't run crates.io sync in the dry run at all right now 🤦 |
Closes: #2141