remove fp16 target feature from some vreinterpret intrinsics#1991
remove fp16 target feature from some vreinterpret intrinsics#1991folkertdev merged 2 commits intorust-lang:mainfrom
Conversation
|
Looks good to me, thank you! |
| assert_instr(nop) | ||
| )] | ||
| #[target_feature(enable = "neon,fp16")] | ||
| #[cfg_attr(target_arch = "arm", target_feature(enable = "fp16"))] |
There was a problem hiding this comment.
I don't believe the fp16 target feature is required on 32-bit either.
There was a problem hiding this comment.
This is what was done in #1978, for stores and loads.
@adamgemmell, do you have ideas?
There was a problem hiding this comment.
vreinterprets are NOPs, so there's no issues with the instruction not being available on 32 bit platforms. If it builds and the tests pass then it's fine to remove for both sets of targets
aa46f8e to
1b44fd0
Compare
|
The second commit is for passing CI. rust-lang/rust#151529 |
|
For context: this includes a fix for miri failing to build |
Usage of them is accepted by clang without
fullfp16(https://godbolt.org/z/dhffa4YT9). It seems that they are missing in #1978.cc @adamgemmell, in case I misunderstood