Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow(redundant_transmutation) for when #136083 gets merged #1711

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bend-n
Copy link

@bend-n bend-n commented Feb 12, 2025

#136083 adds a lint that triggers on avx512f. this allow's it.


warning: this transmute could be performed safely
     --> crates/core_arch/src/x86/avx512f.rs:29273:5
      |
29273 |     transmute(r)
      |     ^^^^^^^^^^^^ help: replace `transmute`: `i8::cast_unsigned(r)`

(many (24) such cases, this one is a transmute of i8 -> __mmask8)

@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks.

@bend-n bend-n changed the title allow_redundant transmutation for when #136083 gets merged allow(redundant_transmutation) for when #136083 gets merged Feb 12, 2025
@sayantn
Copy link
Contributor

sayantn commented Feb 12, 2025

I think it would be better to replace those than allow the lint. It doesn't seem like too much work - only 24 instances

@bend-n
Copy link
Author

bend-n commented Feb 13, 2025

@sayantn

you mean for me to actually cargo fix those warnings?

@sayantn
Copy link
Contributor

sayantn commented Feb 13, 2025

Imo that would be better, and the lint will actually serve its purpose

@bend-n
Copy link
Author

bend-n commented Feb 13, 2025

erm, okay. done (the nightly feature will stabilize on nightly soon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants