Use pre-built cargo-hack in CI #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just started the v0.4.x branch so it's not actually used yet. So let's wait until we merge #320 and we actually start with the master/v0.4 split. |
|
Alright, guess you'll add the v0.4.x branch to CI with #320 then. I've dropped the second commit and updated the PR description. |
The authors of cargo-hack provide an Action to use in CI and avoid having to build from source. Currently the MSRV CI job fails because latest cargo-hack requires 1.56 to build while the test is run with 1.46. Simply running cargo-hack only requies 1.26 though. This should also speedup CI runs, since we don't have to build cargo-hack each time.
Thomasdezeeuw
approved these changes
Aug 13, 2022
|
Thanks @LingMan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pre-built cargo-hack in CI
The authors of cargo-hack provide an Action to use in CI and avoid having to build from source.
Currently the MSRV CI job fails because latest cargo-hack requires 1.56 to build while the test is
run with 1.46.
Simply running cargo-hack only requies 1.26 though.
This should also speedup CI runs, since we don't have to build cargo-hack each time.