Skip to content

fix(cli/rustup-mode): err when trying to show the default/active toolchain but there is none #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Jan 4, 2025

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rami3l rami3l force-pushed the fix/cli-error-code branch from d81c19c to 5e9510c Compare January 6, 2025 13:16
@rami3l rami3l enabled auto-merge January 6, 2025 13:18
@rami3l rami3l added this pull request to the merge queue Jan 6, 2025
Merged via the queue into rust-lang:master with commit 84adf47 Jan 6, 2025
27 checks passed
@rami3l rami3l deleted the fix/cli-error-code branch January 6, 2025 13:56
@weihanglo
Copy link
Member

weihanglo commented Jan 6, 2025

Thanks for the swift fix, people.

I'm not familiar with the release process, though I guess this will be backported to the stable branch for 1.28?

@rami3l
Copy link
Member Author

rami3l commented Jan 10, 2025

I'm not familiar with the release process, though I guess this will be backported to the stable branch for 1.28?

@weihanglo For now stable is just a snapshot of master at some point in time, so, indeed, it will turn stable when we want to update that snapshot and cut the actual release. For now, you can try build from source or take advantage of our CI artifacts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustup default no longer exits with 1 with no default toolchain is set
4 participants