Add arch name to archive files created in the upload workflow #4679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,16 +11,16 @@ jobs: | |||
| matrix: | |||
| build: [linux, macos, windows-gnu, windows-msvc] | |||
| include: | |||
| - build: linux | |||
| - build: linux-x86_64 | |||
There was a problem hiding this comment.
I believe that updating this would require the corresponding values in build so that the matrix legs will still match.
There was a problem hiding this comment.
Will do. I'll push it as a separate commit but if you want me to rebase it into one I can do that too.
There was a problem hiding this comment.
Great thanks! And no worries. In cases like this where the diff is so small it's fine to squash the changes on the original commit, but will just squash on merge
calebcartwright
pushed a commit
to calebcartwright/rustfmt
that referenced
this pull request
Feb 4, 2021
…ang#4679) * Add arch name to archive files created in the upload workflow * Fix arch names in matrix.build key to include arch name as well
calebcartwright
pushed a commit
that referenced
this pull request
Feb 4, 2021
* Add arch name to archive files created in the upload workflow * Fix arch names in matrix.build key to include arch name as well
|
Backported in #4685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful for my ubi tool. It also prepares for doing ARM builds for macOS, which will probably be a thing in the near future.