Skip to content

Fix; for query performance #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 19, 2025
Merged

Fix; for query performance #2246

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5e295ff
Fix for `completed` query performance
Jamesbarford Sep 15, 2025
f936848
add error.aid index
Jamesbarford Sep 15, 2025
859355f
possible fix for in_progress
Jamesbarford Sep 15, 2025
6ada489
removed index on error.aid as previous PR added it
Jamesbarford Sep 17, 2025
b9fd346
PR Feedback; remove `IF NOT EXISTS` from index creation
Jamesbarford Sep 19, 2025
b880a24
PR Feedback; Use an `INNER JOIN`
Jamesbarford Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions database/src/pool/postgres.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,11 @@ static MIGRATIONS: &[&str] = &[

CREATE INDEX error_artifact_idx ON error(aid);
"#,
// For completed requests we take the last N completed. As the total number
// of requests grows to make things fast we need an index on the completed_at
r#"
CREATE INDEX benchmark_request_completed_idx ON benchmark_request(completed_at);
"#,
];

#[async_trait::async_trait]
Expand Down Expand Up @@ -743,10 +748,8 @@ impl PostgresConnection {
UNION
SELECT tag FROM parents
)
SELECT job_queue.*
FROM requests
-- Only get requests that have some jobs
RIGHT JOIN job_queue on job_queue.request_tag = requests.tag
-- Only get the jobs of in_progress requests
SELECT * FROM job_queue INNER JOIN requests ON job_queue.request_tag = requests.tag
")).await.unwrap(),
}),
conn,
Expand Down
Loading