Infra - wire up database for test #2119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamesbarford
commented
May 15, 2025
Jamesbarford
force-pushed
the
infra/add-database-testing-capability
branch
2 times, most recently
from
5a2721b to
ee95395
Compare
Kobzol
reviewed
May 20, 2025
Jamesbarford
force-pushed
the
infra/add-database-testing-capability
branch
from
8ada40f to
9eac5a4
Compare
…support docker containers in githubs CI)
Jamesbarford
force-pushed
the
infra/add-database-testing-capability
branch
from
b33b844 to
998c309
Compare
Kobzol
reviewed
May 20, 2025
There was a problem hiding this comment.
I'm not such a big fan of the Makefile, especially since when running the containers with -d, it becomes too easy to let the container continue running in the background, which can slow down the system until restart. It also won't easily work on Windows. But I don't mind keeping it.
What we should add though is some documentation of this, because if someone just runs cargo test, the failure won't tell them much.
Could you please add a ## How to test section to collector/README.md that explains the need for the Postgres DB in 1-2 sentences and shows the make test command? Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a Makefile too so we can spin it up and down locally.