mention that known-bug test directive takes arguments #2288
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieyouxu
reviewed
Mar 17, 2025
Comment on lines
+418
to
+422
| This directive takes comma-separated issue numbers as arguments, | ||
| each prefixed with a `#`. | ||
| Examples are `//@ known-bug: #12345` and `//@ known-bug: #123, #456`. | ||
| Arbitrary text before the `#` is also accepted, | ||
| example being `rust-lang/rust#12345`. |
There was a problem hiding this comment.
Suggestion: probably sth like
The
known-bugdirective accepts issue numbers or "unknown". Valid forms:
//@ known-bug: #123456(when the issue is on rust-lang/rust)//@ known-bug: rust-lang/chalk#123456(when the issue is on another repo)//@ known-bug: unknown(when there is no known issue yet; preferrably open one if it does not already exist)
jieyouxu
added
S-waiting-on-author
tshepang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2261