-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comment out FIXMEs to not display them on UI #2186
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,9 @@ | |
|
||
<!-- toc --> | ||
|
||
> **FIXME(jieyouxu)** completely revise this chapter. | ||
<!-- | ||
FIXME(jieyouxu) completely revise this chapter. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FTR, this was intentional and I think it's more accurate to display this. But maybe elaborate with:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It even includes a specific username to be resolved from. Why should it appear on the UI? Maybe I don't understand, what value does it bring to that page? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense, I opened #2187 to track this instead. |
||
--> | ||
|
||
Directives are special comments that tell compiletest how to build and interpret | ||
a test. They must appear before the Rust source in the test. They may also | ||
|
@@ -248,10 +250,11 @@ Consider writing the test as a proper incremental test instead. | |
|-------------|--------------------------------------------------------------|------------------------------------------|---------------------------| | ||
| `doc-flags` | Flags passed to `rustdoc` when building the test or aux file | `rustdoc`, `js-doc-test`, `rustdoc-json` | Any valid `rustdoc` flags | | ||
|
||
> **FIXME(rustdoc)**: what does `check-test-line-numbers-match` do? | ||
> | ||
> Asked in | ||
> <https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/What.20is.20the.20.60check-test-line-numbers-match.60.20directive.3F>. | ||
<!-- | ||
**FIXME(rustdoc)**: what does `check-test-line-numbers-match` do? | ||
Asked in | ||
<https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/What.20is.20the.20.60check-test-line-numbers-match.60.20directive.3F>. | ||
--> | ||
|
||
### Pretty printing | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normalization has changed pretty significantly since this chapter was first written iirc, imo we should have a big note at the top of the page saying that things have likely diverged from what is documented here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done that.