Fix `cargo run` on Windows by jyn514 · Pull Request #95254 · rust-lang/rust

jyn514 · 2022-03-23T23:32:36Z

Fixes the following error:

error: failed to run custom build command for `bootstrap v0.0.0 (C:\Users\Walther\git\rust\src\bootstrap)`

Caused by:
  process didn't exit successfully: `C:\Users\Walther\git\rust\target\debug\build\bootstrap-7757a4777dec0f86\build-script-build` (exit code: 101)
  --- stdout
  cargo:rerun-if-changed=build.rs
  cargo:rerun-if-env-changed=RUSTC
  cargo:rustc-env=BUILD_TRIPLE=x86_64-pc-windows-msvc
  cargo:rerun-if-env-changed=PATH

  --- stderr
  thread 'main' panicked at 'assertion failed: rustc.is_absolute()', src\bootstrap\build.rs:22:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed

The problem was that the dir.join check only works with rustc.exe, not rustc.

Thanks @Walther for the help testing the fix!

Helps with #94829.

rust-highfive · 2022-03-23T23:32:39Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

ChrisDenton · 2022-03-24T00:28:50Z

I don't know if rustc currently builds on any other platforms that have executable suffixes but maybe using std::env::consts::EXE_SUFFIX might be more future proof?

Fixes the following error: ``` error: failed to run custom build command for `bootstrap v0.0.0 (C:\Users\Walther\git\rust\src\bootstrap)` Caused by: process didn't exit successfully: `C:\Users\Walther\git\rust\target\debug\build\bootstrap-7757a4777dec0f86\build-script-build` (exit code: 101) --- stdout cargo:rerun-if-changed=build.rs cargo:rerun-if-env-changed=RUSTC cargo:rustc-env=BUILD_TRIPLE=x86_64-pc-windows-msvc cargo:rerun-if-env-changed=PATH --- stderr thread 'main' panicked at 'assertion failed: rustc.is_absolute()', src\bootstrap\build.rs:22:5 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace warning: build failed, waiting for other jobs to finish... error: build failed ``` The problem was that the `dir.join` check only works with rustc.exe, not rustc. Thanks Walther for the help testing the fix!

Mark-Simulacrum · 2022-04-06T14:08:07Z

+/// Given an executable called `name`, return the filename for the
+/// executable for a particular target.
+pub fn exe(name: &PathBuf) -> PathBuf {
+    if EXE_EXTENSION != "" && name.extension() != Some(EXE_EXTENSION.as_ref()) {


It seems like this method is basically name.with_extension(EXE_EXTENSION)? Unless I'm missing something, that's the intent of the code...

The difference is this doesn't replace any existing extension. with_extension will change my.file to my.exe.

jyn514 · 2022-04-06T14:11:29Z

@rustbot ready

#95254 (comment)

jyn514 · 2022-04-09T14:23:42Z

Hi @Mark-Simulacrum , I saw you marked this as waiting on author, but I'm not sure why? with_extension has different behavior. https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=c39259bf36bf9e0ee79b136b3978b27c

That said it's very unlikely for this to actually come up, so I'm ok with using with_extension to get this landed.

jyn514 · 2022-04-09T14:23:46Z

@rustbot ready

Mark-Simulacrum · 2022-04-09T14:46:37Z

Seems okay, I think the author status was probably just a race with each other (I don't recall seeing your comment so probably I either by accident changed the wrong PR or something else went wrong).

@bors r+

bors · 2022-04-09T14:46:39Z

📌 Commit 76d7bcc has been approved by Mark-Simulacrum

…imulacrum Fix `cargo run` on Windows Fixes the following error: ``` error: failed to run custom build command for `bootstrap v0.0.0 (C:\Users\Walther\git\rust\src\bootstrap)` Caused by: process didn't exit successfully: `C:\Users\Walther\git\rust\target\debug\build\bootstrap-7757a4777dec0f86\build-script-build` (exit code: 101) --- stdout cargo:rerun-if-changed=build.rs cargo:rerun-if-env-changed=RUSTC cargo:rustc-env=BUILD_TRIPLE=x86_64-pc-windows-msvc cargo:rerun-if-env-changed=PATH --- stderr thread 'main' panicked at 'assertion failed: rustc.is_absolute()', src\bootstrap\build.rs:22:5 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace warning: build failed, waiting for other jobs to finish... error: build failed ``` The problem was that the `dir.join` check only works with `rustc.exe`, not `rustc`. Thanks `@Walther` for the help testing the fix! Helps with rust-lang#94829.

bors · 2022-04-10T03:58:57Z

⌛ Testing commit 76d7bcc with merge f7b4824...

bors · 2022-04-10T06:28:33Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing f7b4824 to master...

rust-timer · 2022-04-10T07:42:10Z

This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

rust-highfive assigned Mark-Simulacrum Mar 23, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2022

jyn514 force-pushed the fix-windows-builds branch from c379355 to 37835dc Compare March 23, 2022 23:34

jyn514 force-pushed the fix-windows-builds branch from 37835dc to dcd7dbf Compare March 24, 2022 00:47

This comment has been minimized.

Sign in to view

jyn514 force-pushed the fix-windows-builds branch from dcd7dbf to 76d7bcc Compare March 24, 2022 00:55

jyn514 mentioned this pull request Mar 24, 2022

Tracking Issue for removing python as the main bootstrap entry point #94829

Open

15 tasks

Mark-Simulacrum reviewed Apr 6, 2022

View reviewed changes

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 6, 2022

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 9, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2022

Dylan-DPC mentioned this pull request Apr 9, 2022

Rollup of 6 pull requests #95869

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 10, 2022

bors merged commit f7b4824 into rust-lang:master Apr 10, 2022

rustbot added this to the 1.62.0 milestone Apr 10, 2022

jyn514 deleted the fix-windows-builds branch April 10, 2022 15:22

Uh oh!

Conversation

jyn514 commented Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Mar 23, 2022

Uh oh!

ChrisDenton commented Mar 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Mark-Simulacrum Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

jyn514 Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

jyn514 commented Apr 6, 2022

Uh oh!

jyn514 commented Apr 9, 2022

Uh oh!

jyn514 commented Apr 9, 2022

Uh oh!

Mark-Simulacrum commented Apr 9, 2022

Uh oh!

bors commented Apr 9, 2022

Uh oh!

bors commented Apr 10, 2022

Uh oh!

bors commented Apr 10, 2022

Uh oh!

rust-timer commented Apr 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jyn514 commented Mar 23, 2022 •

edited

Loading

ChrisDenton commented Mar 24, 2022 •

edited

Loading