rustdoc: fix colors for top buttons and search box

[jsha]

Previously these had a lighter border than the search box.

Before:

After:

Also, remove background-color on .in-band

This was overwriting the style for :target on impl headings. Instead of showing the whole summary of a :target'ed heading as yellow (on light theme), it would show the summary as white.

Before:

After:

Demo: https://rustdoc.crud.net/jsha/ayu-border-color/std/string/trait.ToString.html

[rust-highfive]

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd

[rust-highfive]

r? @CraftSpider

(rust-highfive has picked a reviewer for you, use r? to override)

[jsha]

r? @GuillaumeGomez

[GuillaumeGomez]

Could you add a GUI test to check that the search input has the same border color as the other buttons please?

[jsha]

Updated to add the test. Also made the change a little bigger: The icon contents now have the same color as their border, on all themes. And the background of the search box in dark theme is now the background of the page overall, which matches the design of ayu and light. This avoids having a big white box that stands out from the rest of the page.

I also adjusted the crate-search dropdown slightly to match. It has the same background now, and gained a slight border to distinguish it.

[GuillaumeGomez]

There some rules missing in the themes apparently said the CI.

[GuillaumeGomez]

The new border color makes elements difficult to notice (it looks fine - for me - on the ayu theme):

Also, I don't think you added a GUI test when an impl ID is in the URLto check its background color?

[jsha]

On light theme, the border color is the same as it's been. The only change there is that I had dimmed the button contents (? and ⚙️) to match the border color. I pushed a new revision with the button contents restored to higher contrast. What do you think?

[rust-log-analyzer]

The job x86_64-gnu-llvm-12 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustdoc-themes v0.1.0 (/checkout/src/tools/rustdoc-themes)
    Finished release [optimized] target(s) in 0.46s
rustdoc: [check-theme] Starting tests! (Ignoring all other arguments)
 - Checking "/checkout/src/librustdoc/html/static/css/themes/ayu.css"... FAILED
  Missing "#theme-picker:hover,#theme-picker:focus,#settings-menu:hover,#settings-menu:focus,#help-button:hover,#help-button:focus" rule
  Missing "#theme-picker,#settings-menu,#help-button,#crate-search,.search-input" rule
 - Checking "/checkout/src/librustdoc/html/static/css/themes/dark.css"... FAILED
  Missing "#theme-picker:hover,#theme-picker:focus,#settings-menu:hover,#settings-menu:focus,#help-button:hover,#help-button:focus" rule

[GuillaumeGomez]

Still find it hard to see but better indeed.

[bors]

☔ The latest upstream changes (presumably #94095) made this pull request unmergeable. Please resolve the merge conflicts.

[JohnCSimon]

ping from triage:
@jsha
returning to you to address build failures + conflicts

[Dylan-DPC]

Closing this as inactive