Rollup of 11 pull requests #73235
Merged
Rollup of 11 pull requests #73235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular matching on complex types such as strings will cause deep recursion to happen. Fixes rust-lang#72933
Fixes more of: clippy::unused_unit clippy::op_ref clippy::useless_format clippy::needless_return clippy::useless_conversion clippy::bind_instead_of_map clippy::into_iter_on_ref clippy::redundant_clone clippy::nonminimal_bool clippy::redundant_closure clippy::option_as_ref_deref clippy::len_zero clippy::iter_cloned_collect clippy::filter_next
`saturating_add` example was not parameterized, but passed because the `u8` would saturate successfully
Co-authored-by: lzutao <[email protected]>
Fix `is_const_context`, update `check_for_cast` A better version of rust-lang#71477 Adds `fn enclosing_body_owner` and uses it in `is_const_context`. `is_const_context` now uses the same mechanism as `mir_const_qualif` as it was previously incorrect. Renames `is_const_context` to `is_inside_const_context`. I also updated `check_for_cast` in the second commit, so r? @estebank (I removed one lvl of indentation, so it might be easier to review by hiding whitespace changes)
…i-obk Ensure stack when building MIR for matches In particular matching on complex types such as strings will cause deep recursion to happen. Fixes rust-lang#72933 r? @matthewjasper @oli-obk
…an-DPC Clean up E0642 explanation r? @Dylan-DPC
…_doc-ref-fix, r=ollie27 doc/rustdoc: Fix incorrect external_doc feature flag
…ixes, r=Xanewok save_analysis: better handle paths and functions signature This should improve slightly some possible regressions due to hir rework. r? @Xanewok
…enkov Add new E0762 error code
Fix more clippy warnings Fixes more of: clippy::unused_unit clippy::op_ref clippy::useless_format clippy::needless_return clippy::useless_conversion clippy::bind_instead_of_map clippy::into_iter_on_ref clippy::redundant_clone clippy::nonminimal_bool clippy::redundant_closure clippy::option_as_ref_deref clippy::len_zero clippy::iter_cloned_collect clippy::filter_next r? @Dylan-DPC
Automatically prioritize unsoundness issues r? @spastorino cc @Mark-Simulacrum @rust-lang/wg-prioritization
…laumeGomez Support proc macros in intra doc link resolution The feature was written pre-proc macro resolution, so it only supported the wacky MBE resolution rules. This adds support for proc macros as well. cc @GuillaumeGomez Fixes rust-lang#73173
Fix doctest template `saturating_add` example was not parameterized, but passed because the `u8` would saturate successfully
x.py: with --json-output, forward cargo's JSON Fixes rust-lang#73209 r? @Mark-Simulacrum
|
@bors r+ p=11 rollup=never |
|
📌 Commit ba0a8d2 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
This was referenced Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
is_const_context, updatecheck_for_cast#72380 (Fixis_const_context, updatecheck_for_cast)Failed merges:
r? @ghost