Code

Fully implement or-pattern parsing#63693

Code

Merged

bors merged 34 commits intorust-lang:masterrust-lang/rust:masterfrom

Centril:polish-parse-or-patsCentril/rust:polish-parse-or-patsCopy head branch name to clipboard

Aug 27, 2019

Commits

Commits on Aug 24, 2019

• parser: extract `ban_unexpected_or_or`.

  Centril

  committed
  5299d8a

  Copy full SHA for 5299d8a

• parser: type alias `type Expected = Option<&'static str>;`.

  Centril

  committed
  1ba7550

  Copy full SHA for 1ba7550

• parser: refactor `parse_pat_with_or` + use it in [p0, p1, ..] pats.

  Centril

  committed
  0bbea47

  Copy full SHA for 0bbea47

• parser: improve or-patterns recovery.

  Centril

  committed
  30b841d

  Copy full SHA for 30b841d

• parser: move `multiple-pattern-typo` -> `or-patterns` directory.

  Centril

  committed
  d34ee76

  Copy full SHA for d34ee76

• parser: `multiple-pattern-typo`: cover more or-pattern places.

  Centril

  committed
  5f57fee

  Copy full SHA for 5f57fee

• parser: simplify `parse_pat_with_or`.

  Centril

  committed
  f852c7c

  Copy full SHA for f852c7c

• parser: extract `maybe_recover_unexpected_comma`.

  Centril

  committed
  21d9b85

  Copy full SHA for 21d9b85

• parser: integrate `maybe_recover_unexpected_comma` in `parse_pat_with_or`.

  Centril

  committed
  a4a34ab

  Copy full SHA for a4a34ab

• parser: extract `eat_or_separator`.

  Centril

  committed
  7b59b4f

  Copy full SHA for 7b59b4f

• parser: improve `parse_pat_with_or` docs.

  Centril

  committed
  dc5bbaf

  Copy full SHA for dc5bbaf

• parser: use `eat_or_separator` for leading vert.

  Centril

  committed
  6498959

  Copy full SHA for 6498959

• parser: move `maybe_recover_unexpected_comma` to a more appropriate place.

  Centril

  committed
  39f5e5b

  Copy full SHA for 39f5e5b

• parser: document `ban_unexpected_or_or`.

  Centril

  committed
  8f6a0cd

  Copy full SHA for 8f6a0cd

• parser: `parse_pats` -> `parse_top_pat{_unpack}`.

  Centril

  committed
  b7178ef

  Copy full SHA for b7178ef

• parser: document `parse_pat`.

  Centril

  committed
  92d66a1

  Copy full SHA for 92d66a1

• parser: `let` stmts & `for` exprs: allow or-patterns.

  Centril

  committed
  95792b4

  Copy full SHA for 95792b4

• parser: drive-by: simplify `parse_arg_general`.

  Centril

  committed
  5f6bec8

  Copy full SHA for 5f6bec8

• move `ui/or-pattern-mismatch` -> `ui/or-patterns/`.

  Centril

  committed
  a9af18b

  Copy full SHA for a9af18b

• or-patterns: add syntactic tests.

  Centril

  committed
  f35432e

  Copy full SHA for f35432e

• move `feature-gate-or_patterns.*` -> `ui/or-patterns/`

  Centril

  committed
  d3b3bce

  Copy full SHA for d3b3bce

• or-patterns: harden feature gating tests.

  Centril

  committed
  1ffea18

  Copy full SHA for 1ffea18

• parser: better recovery for || in inner pats.

  Centril

  committed
  b205055

  Copy full SHA for b205055

• parser: bool -> GateOr.

  Centril

  committed
  b2966e6

  Copy full SHA for b2966e6

• parser: bool -> TopLevel.

  Centril

  committed
  a9ef859

  Copy full SHA for a9ef859

• parse_top_pat: silence leading vert gating sometimes.

  Centril

  committed
  3a40542

  Copy full SHA for 3a40542

• parser: extract recover_inner_leading_vert.

  Centril

  committed
  e374772

  Copy full SHA for e374772

• parser: reword || recovery.

  Centril

  committed
  0ab8430

  Copy full SHA for 0ab8430

• parser: simplify parse_pat_with_or_{inner}

  Centril

  committed
  1202cb0

  Copy full SHA for 1202cb0

• parser: 'while parsing this or-pattern...'

  Centril

  committed
  083963e

  Copy full SHA for 083963e

Commits on Aug 25, 2019

• parser: gracefully handle `fn foo(A | B: type)`.

  Centril

  committed
  1caaa40

  Copy full SHA for 1caaa40

• or_patterns: add run-rustfix tests.

  Centril

  committed
  6a73199

  Copy full SHA for 6a73199

• parser: TopLevel -> RecoverComma.

  Centril

  committed
  acb1130

  Copy full SHA for acb1130

Commits on Aug 26, 2019

• parser: fix span for leading vert.

  Centril

  committed
  2bd27fb

  Copy full SHA for 2bd27fb