Skip to content

Stabilize tool_attributes #52982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions src/doc/unstable-book/src/language-features/tool-attributes.md

This file was deleted.

6 changes: 2 additions & 4 deletions src/libsyntax/feature_gate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,6 @@ declare_features! (
// Access to crate names passed via `--extern` through prelude
(active, extern_prelude, "1.27.0", Some(44660), Some(Edition::Edition2018)),

// Scoped attributes
(active, tool_attributes, "1.25.0", Some(44690), None),
// Scoped lints
(active, tool_lints, "1.28.0", Some(44690), None),

Expand Down Expand Up @@ -619,6 +617,8 @@ declare_features! (
(accepted, repr_transparent, "1.28.0", Some(43036), None),
// Defining procedural macros in `proc-macro` crates
(accepted, proc_macro, "1.29.0", Some(38356), None),
// Scoped attributes
(accepted, tool_attributes, "1.29.0", Some(44690), None),
);

// If you change this, please modify src/doc/unstable-book as well. You must
Expand Down Expand Up @@ -1199,8 +1199,6 @@ impl<'a> Context<'a> {
// so we skip this then
if !is_macro {
if attr.is_scoped() {
gate_feature!(self, tool_attributes, attr.span,
&format!("scoped attribute `{}` is experimental", attr.path));
if attr::is_known_tool(attr) {
attr::mark_used(attr);
} else {
Expand Down
15 changes: 0 additions & 15 deletions src/test/compile-fail/feature-gate-tool_attributes.rs

This file was deleted.

1 change: 0 additions & 1 deletion src/test/compile-fail/unknown-tool-name.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![feature(tool_attributes)]

#![foo::bar] //~ ERROR an unknown tool name found in scoped attribute: `foo::bar`. [E0694]

Expand Down
3 changes: 1 addition & 2 deletions src/test/compile-fail/unknown_tool_attributes-1.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,5 @@
#![feature(custom_attributes)]

#[foo::bar]
//~^ ERROR scoped attribute `foo::bar` is experimental (see issue #44690) [E0658]
//~^^ ERROR an unknown tool name found in scoped attribute: `foo::bar`. [E0694]
//~^ ERROR an unknown tool name found in scoped attribute: `foo::bar`. [E0694]
fn main() {}
1 change: 0 additions & 1 deletion src/test/run-pass/tool_attributes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

// Scoped attributes should not trigger an unused attributes lint.

#![feature(tool_attributes)]
#![deny(unused_attributes)]

fn main() {
Expand Down
15 changes: 0 additions & 15 deletions src/test/ui/feature-gate-tool_attributes.rs

This file was deleted.

11 changes: 0 additions & 11 deletions src/test/ui/feature-gate-tool_attributes.stderr

This file was deleted.