erase lifetimes when translating specialized substs #38249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Projections can generate lifetime variables with equality constraints, that will not be resolved by `resolve_type_vars_if_possible`, so substs need to be lifetime-erased after that. Fixes rust-lang#36848.
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 55180d0 has been approved by |
|
⌛ Testing commit 55180d0 with merge e97a979... |
|
💔 Test failed - auto-win-msvc-64-cargotest |
|
@bors: retry
…On Sat, Dec 10, 2016 at 10:32 PM bors ***@***.***> wrote:
💔 Test failed - auto-win-msvc-64-cargotest
<https://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/2558>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38249 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95FcMEC-O2B3-GDKTayhdOCiE47JPks5rG5jqgaJpZM4LIUAK>
.
|
bors
added a commit
that referenced
this pull request
Dec 11, 2016
erase lifetimes when translating specialized substs Projections can generate lifetime variables with equality constraints, that will not be resolved by `resolve_type_vars_if_possible`, so substs need to be lifetime-erased after that. Fixes #36848.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projections can generate lifetime variables with equality constraints,
that will not be resolved by
resolve_type_vars_if_possible, so substsneed to be lifetime-erased after that.
Fixes #36848.