-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add links to how to disable the default prelude #31900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Running `grep -r no_implicit_prelude doc src/{libstd,libcore}` resulted in only the one hit in the reference. Added links from the documentation for `std::prelude` and `core::prelude::v1` to make it easier to find.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
I think |
Finally finished building (under 2 hours 😄) and the links work fine. |
I... don't think that this was intended to be stable actually, it's probably a mistake that it's accepted on the stable compiler. We have an accepted RFC to rename this attribute but unfortunately the tracking issue has seen very little activity. |
Prelude mechanics will likely require some rethinking after the name resolution reform. |
Heh, I did search the issues for |
@alexcrichton would no_prelude be stable if #20561 were implemented, or are there reasons to not want this stabilised yet? |
I think that |
Ok, I was thinking I could maybe look at implementing #20561 in the next few days to try and get it moving towards stabilisation. I guess |
Oh that'd be great to get that implemented! We'd probably want to hold off documentation in the prelude itself until its stable, but there are nightly sections of the docs it would fit well into. |
Cool, I should hopefully get to it in the next week assuming it's not to hard. Thanks for the input. |
Running
grep -r no_implicit_prelude doc src/{libstd,libcore}
resulted in onlythe one hit in the reference. Added links from the documentation for
std::prelude
andcore::prelude::v1
to make it easier to find.r? @steveklabnik