Rollup of 10 pull requests #152442
Closed
Rollup of 10 pull requests #152442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Hide common linker output behind `linker-info` - Add tests - Account for different capitalization on windows-gnu when removing "warning" prefix - Add some more comments - Add macOS deployment-target test - Ignore linker warnings from trying to statically link glibc I don't know what's going on in `nofile-limit.rs` but I want no part of it. - Use a fake linker so tests are platform-independent
Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity.
…e observed on stable
Keys and values now must be `Copy` due to erasing.
The derived version is equivalent to the hand-written version.
The latter is a new module. As well as the code motion, some other changes were required. - `QueryJobId` methods became free functions so they could move while `QueryJobId` itself stayed put. This was so `QueryMap` and `QueryJobInfo` could be moved. - Some visibilities in `rustc_query_system` required changing. - `collect_active_jobs_from_all_queries` is no longer required in `trait QueryContext`.
Because all uses are now in `rustc_query_impl`. This was made possible by the previous commit. Less code in `rustc_middle`, hooray.
From `rustc_query_system::query::job` to `rustc_query_impl::job`.
…rmal attribute logic instead of special cased checks
try enabling `linker-messages` by default again - Split out `linker-info` from `linker-messages` - Make `linker-messages` warn-by-default; keep `linker-info` deny-by-default Helps with rust-lang#136096.
Use function shims to make sure EII works on apple targets Use function shims to make sure EII works on apple targets (and generally accepts target-arch attributes) Explainer: rust-lang#146348 (comment) Tracking issue: rust-lang#125418
…etrochenkov Don't ICE on layout error in vtable computation Fixes rust-lang#152030. Note: I'm including a more general testcase that doesn't use the feature in the original report, but only reproduces with debuginfo disabled. Does it make sense to also include the original testcase?
…ode, r=Zalathar Move more query system code Towards the goal of eliminating `rustc_query_system`, this commit moves some code from `rustc_query_system` to `rustc_middle` and `rustc_query_impl`, and from `rustc_middle` to `rustc_query_impl`. r? @Zalathar
…jdonszelmann Restrict the set of things that const stability can be applied to r? @jdonszelmann
…ati865 Reenable a GCI+mGCA+GCPT test case The GCI+mGCA+GCPT test case can now be made to work with the necessary features and tweaks.
Support ADT types in type info reflection Tracking issue: rust-lang#146922 `#![feature(type_info)]` This PR supports ADT types for feature `type_info` reflection. (It's still a draft PR, with implementation in progress) Note that this PR does not take SemVer into consideration (I left a FIXME comment). As discussed earlier ([comment](rust-lang#146923 (comment))), this requires further discussion. However, I hope we could get an initial implementation to land first, so we can start playing with it. ### Progress / Checklist - [x] Struct support. - [x] Enum - [x] Union - [x] Generics - [ ] ~Methods~ Implemented and to be implemented in other PRs - [ ] ~Traits~ Implemented and to be implemented in other PRs - [x] Rebasing PR to `main` branch ~~(It's currently based on PR rust-lang#151123, so here's an extra commit)~~ - [x] Cleanup and Rebase. - [x] Fix field info for references. (see [comment](rust-lang#151142 (comment))) r? @oli-obk
…s-wfck, r=BoxyUwU mGCA: Add associated const type check rust-lang#151642 r? BoxyUwU I didn't bless tests just yet as it only fixes the dyn arm
…n, r=mati865 style: remove unneeded trailing commas Make format-like macro calls look similar to what `cargo fmt` does automatically - remove trailing commas. When removing a comma, I also inlined some variables for consistency and clarity. I'm working on a [clippy lint](rust-lang/rust-clippy#16530) to make this process automatic.
… r=TaKO8Ki BikeshedGuaranteedNoDrop trait: add comments indicating that it can be observed on stable Not sure if that's worth it, maybe this goes without saying for all these builtin traits?
rustbot
added
A-attributes
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors
bot
added
S-waiting-on-author
Contributor
|
PR #149937, which is a member of this rollup, was unapproved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
linker-messagesby default again #149937 (try enablinglinker-messagesby default again)r? @ghost
Create a similar rollup