Move error emitted by attrs #[rustc_symbol_name] and #[rustc_def_path] from codegen pass to check_attr.rs
#152368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
rustbot
added
A-attributes
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
might be good to do a perf run? |
instead just check and emit this attribute error through `check_attr.rs`
Bryntet
force-pushed
the
symbol-attrs-check
branch
from
cdc764e to
d1cb52c
Compare
Contributor
|
r? me |
JonathanBrouwer
requested changes
Feb 9, 2026
| // if the `rustc_attrs` feature is not enabled, then the | ||
| // attributes we are interested in cannot be present anyway, so | ||
| // skip the walk. | ||
| if !tcx.features().rustc_attrs() { |
Contributor
There was a problem hiding this comment.
Because of this check there shouldn't be any perf difference, this will be false for any realistic crate
rustbot
removed
the
S-waiting-on-review
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
Contributor
|
☔ The latest upstream changes (presumably #152373) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to emit the errors, during codegen we iterate over all feasible targets that these attributes could be placed on, this PR changes it so that we just emit these errors in the
check_attrstep of attribute parsing, since this check is guaranteed to already iterate through all attributes, it should (I think), be a little bit faster to emit from there instead