Improve the inline_fluent! macro
#152356
Open
Improve the inline_fluent! macro
#152356
+320
−275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
3 tasks
JonathanBrouwer
changed the title
inline_fluent! macro and rename it to msg!inline_fluent! macro
JonathanBrouwer
force-pushed
the
inline_diag4
branch
from
e7ad0ed to
4cc0202
Compare
Contributor
Author
Collaborator
|
cc @davidtwco, @TaKO8Ki
cc @davidtwco, @TaKO8Ki Some changes occurred to the CTFE machinery |
rustbot
added
S-waiting-on-review
Contributor
Author
|
Don't merge together with #152276, these will soft-conflict |
Contributor
|
don't merge, #152276 goes first |
JonathanBrouwer
force-pushed
the
inline_diag4
branch
from
4cc0202 to
6eb2a8f
Compare
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri |
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
Soft conflict is now resolved, safe to merge :) |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
2 similar comments
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #151366
This PR turns
inline_fluent!into a proc macro, so we can run validation on the messages in this macro :)I started a thread here because I don't like the name of the macro, but that's for a future PR: #t-compiler > Bikeshed the new `inline_fluent!` macro