-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
stabilize new RangeToInclusive type #152304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
stabilizes `core::range::RangeToInclusive`
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a small change needed here but otherwise LGTM. However, I noticed there are some trait implementations missing compared to ops::RangeToInclusive:
OneSidedRange<T>RangeBounds<T> for RangeToInclusive<&T>(currently has forRangeToInclusive<T>SliceIndex<ByteStr> for RangeToInclusive<usize>SliceIndex<str> for RangeToInclusive<usize>
Would you mind putting up a PR adding those? We can re-nominate this for libs-api after.
| #[unstable(feature = "range_into_bounds", issue = "136903")] | ||
| #[stable(feature = "new_range_to_inclusive_api", since = "CURRENT_RUSTC_VERSION")] | ||
| #[rustc_const_unstable(feature = "const_range", issue = "none")] | ||
| impl<T> const IntoBounds<T> for RangeToInclusive<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this remain unstable under range_into_bounds?
|
Reminder, once the PR becomes ready for a review, use |
|
|
stabilizes
core::range::RangeToInclusiveTracking issue: #125687
r? @tgross35