Fix an ICE in the vtable iteration for a trait reference in const eval when a supertrait not implemented#152287
Open
jakubadamw wants to merge 2 commits intorust-lang:mainfrom
Open
Fix an ICE in the vtable iteration for a trait reference in const eval when a supertrait not implemented#152287jakubadamw wants to merge 2 commits intorust-lang:mainfrom
jakubadamw wants to merge 2 commits intorust-lang:mainfrom
Conversation
…l when a supertrait not implemented compiler/rustc_trait_selection/src/traits/vtable.rs@`vtable_entries`: The impossible predicates check in `vtable_entries` used `instantiate_own` which only includes the method's own where-clauses, not the parent trait's bounds. Replace it with `instantiate_and_check_impossible_predicates` which also checks the trait ref itself, so unsatisfied supertrait bounds are caught and the method is marked `Vacant` instead of ICEing.
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compiler/rustc_trait_selection/src/traits/vtable.rs@
vtable_entries:The impossible predicates check in
vtable_entriesusedinstantiate_ownwhich only includes the method's ownwhereclauses, without the parent trait's bounds. Replace it withinstantiate_and_check_impossible_predicateswhich also checks the trait ref itself, so unsatisfied supertrait bounds are caught and the method is markedVacantinstead of ICEing.Closes #137190.
Closes #135470.