Properly pass offload sizes to kernel args#152283
Open
Sa4dUs wants to merge 1 commit intorust-lang:mainfrom
Open
Properly pass offload sizes to kernel args#152283Sa4dUs wants to merge 1 commit intorust-lang:mainfrom
Sa4dUs wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-LLVM
Sa4dUs
force-pushed
the
offload-handle-alloca
branch
from
7e0a135 to
cdc35ab
Compare
This comment has been minimized.
This comment has been minimized.
Sa4dUs
force-pushed
the
offload-handle-alloca
branch
from
cdc35ab to
b454716
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRs prevents offload from creating an unnecessary alloca when all the arg sizes are static.
I'll implement the first dynamic-size data type in a follow up PR (slice support).
r? @ZuseZ4