borrowck: suggest &mut *x for pattern reborrows
#152281
Open
+175
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
JohnTitor
commented
Feb 7, 2026
Comment on lines
+12
to
+19
| help: consider making the binding mutable if you need to reborrow multiple times | ||
| | | ||
| LL | fn test(mut outer: &mut Option<i32>) { | ||
| | +++ | ||
| help: to reborrow the mutable reference, add `*` | ||
| | | ||
| LL | match (&mut *outer, 23) { | ||
| | + |
Member
Author
There was a problem hiding this comment.
Here's a discussion point, maybe we should dedup help annotations.
I don't have strong preference and would like to follow someone's favor.
This comment has been minimized.
This comment has been minimized.
JohnTitor
force-pushed
the
sugg-mut-deref-borrows
branch
from
9d683c6 to
0de7415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81059
r? @estebank as you should have some context here, but feel free to re-assign if you don't have time to review right now.