Skip to content

Convert to inline diagnostics in rustc_lint #152217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 4 commits into from
Feb 8, 2026
Merged

Convert to inline diagnostics in rustc_lint #152217

rust-bors merged 4 commits into from
Feb 8, 2026
+1,492 −5,593

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Feb 6, 2026

For #151366
r? @jdonszelmann
This was a big one! Second to last one, rustc_parse is the last one and even bigger :P

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 6, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 6, 2026
Open
3 tasks
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer
JonathanBrouwer commented Feb 6, 2026
View reviewed changes
compiler/rustc_lint/src/lints.rs
#[help]
#[diag("`#[{$name}]` attribute cannot be used on {$target}")]
#[warning(
"this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!"
Copy link
Contributor Author

@JonathanBrouwer JonathanBrouwer Feb 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some messages, especially this one are duplicated a few times because there is no good way to make a constant out of these with the current derive code yet.
I'm planning to go through all the messages and seeing what I can dedup after all crates are converted

@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2026

rustc_macros::diagnostics was changed

cc @davidtwco, @TaKO8Ki

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 7, 2026
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer

This comment was marked as outdated.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 7, 2026 •
edited
Loading

Rebased again because of conflicts, now the entire diff should be clean :)
FYI CI was green before the rebase

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Feb 7, 2026

Ok looked it over, pretty sure this is all okay. It's big but nothing too weird I think and this one would be great to have merged so let's go :3

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Feb 7, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 7, 2026

📌 Commit c2d6d93 has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152217 - JonathanBrouwer:convert_line, r=jd…
166651d 
…onszelmann

Convert to inline diagnostics in `rustc_lint`

For rust-lang#151366
r? @jdonszelmann
This was a big one! Second to last one, `rustc_parse` is the last one and even bigger :P
@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 7, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 7, 2026

@bors r=jdonszelmann

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 7, 2026

📌 Commit e304c21 has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 7, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 7, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152217 - JonathanBrouwer:convert_line, r=jd…
dfad95c 
…onszelmann

Convert to inline diagnostics in `rustc_lint`

For rust-lang#151366
r? @jdonszelmann
This was a big one! Second to last one, `rustc_parse` is the last one and even bigger :P
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 7, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 7, 2026
@bors
Auto merge of #152307 - JonathanBrouwer:rollup-ZfPovD7, r=JonathanBro…
cb7d131 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #151745 (Remove a couple of unnecessary flags and env vars in bootstrap)
 - #152217 (Convert to inline diagnostics in `rustc_lint`)
 - #152056 (RwLock: refine documentation to emphasize non-reentrancy guarantees)
 - #152261 (Introduce helper `ty::Generics::has_own_self`)
 - #152288 (Allow only a single accepter per attribute)
 - #152292 (Minor change for readability)
 - #152300 (Port `rustc_regions` to the new attribute parser)
@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 7, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 7, 2026

⚠️ A new commit 580c8d3c20ca3b363ece4ec34a9db1194bb9940d was pushed to the branch, the PR will need to be re-approved.

@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 7, 2026
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Feb 7, 2026

@bors r=jdonszelmann

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 7, 2026

📌 Commit 580c8d3 has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 7, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 7, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 7, 2026
@bors
Auto merge of #152308 - JonathanBrouwer:rollup-3QU52Xc, r=JonathanBro…
866f30e 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #151745 (Remove a couple of unnecessary flags and env vars in bootstrap)
 - #152217 (Convert to inline diagnostics in `rustc_lint`)
 - #152056 (RwLock: refine documentation to emphasize non-reentrancy guarantees)
 - #152261 (Introduce helper `ty::Generics::has_own_self`)
 - #152288 (Allow only a single accepter per attribute)
 - #152292 (Minor change for readability)
 - #152300 (Port `rustc_regions` to the new attribute parser)
rust-bors bot pushed a commit that referenced this pull request Feb 7, 2026
@bors
Auto merge of #152308 - JonathanBrouwer:rollup-3QU52Xc, r=JonathanBro…
568b4a1 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #151745 (Remove a couple of unnecessary flags and env vars in bootstrap)
 - #152217 (Convert to inline diagnostics in `rustc_lint`)
 - #152056 (RwLock: refine documentation to emphasize non-reentrancy guarantees)
 - #152261 (Introduce helper `ty::Generics::has_own_self`)
 - #152288 (Allow only a single accepter per attribute)
 - #152292 (Minor change for readability)
 - #152300 (Port `rustc_regions` to the new attribute parser)
rust-bors bot pushed a commit that referenced this pull request Feb 7, 2026
@bors
Auto merge of #152308 - JonathanBrouwer:rollup-3QU52Xc, r=JonathanBro…
c69e1a0 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #151745 (Remove a couple of unnecessary flags and env vars in bootstrap)
 - #152217 (Convert to inline diagnostics in `rustc_lint`)
 - #152056 (RwLock: refine documentation to emphasize non-reentrancy guarantees)
 - #152261 (Introduce helper `ty::Generics::has_own_self`)
 - #152288 (Allow only a single accepter per attribute)
 - #152292 (Minor change for readability)
 - #152300 (Port `rustc_regions` to the new attribute parser)
@rust-bors rust-bors bot merged commit e96bcca into rust-lang:main Feb 8, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 8, 2026
rust-timer added a commit that referenced this pull request Feb 8, 2026
@rust-timer
Unrolled build for #152217
e013b7b 
Rollup merge of #152217 - JonathanBrouwer:convert_line, r=jdonszelmann

Convert to inline diagnostics in `rustc_lint`

For #151366
r? @jdonszelmann
This was a big one! Second to last one, `rustc_parse` is the last one and even bigger :P
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdonszelmann jdonszelmann

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanBrouwer @rustbot @rust-log-analyzer @jdonszelmann